In case of search add "Searching..." string to the spinner in the center.

In case of search add "Searching..." string to the spinner in the center.


BUG=137994
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149153

[Vladislav Kaznacheev, 2012-07-30 11:19:46]

lgtm

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/css/file_manager.css:512: .spinner {
It might be not obvious but this CSS class is used in 3 more places in the Files
app which this change is likely to break.

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:3320: if
(this.directoryModel_.isSearching()) {
I suggest keeping a single DOM element for both uses but show/hide the text
depending on an extra class or attribute.

[Vladislav Kaznacheev, 2012-07-30 11:20:11]

Sorry, I clicked LGTM by mistake.

On 2012/07/30 11:19:46, Vladislav Kaznacheev wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
> File chrome/browser/resources/file_manager/css/file_manager.css (right):
> 
>
https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
> chrome/browser/resources/file_manager/css/file_manager.css:512: .spinner {
> It might be not obvious but this CSS class is used in 3 more places in the
Files
> app which this change is likely to break.
> 
>
https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
> chrome/browser/resources/file_manager/js/file_manager.js:3320: if
> (this.directoryModel_.isSearching()) {
> I suggest keeping a single DOM element for both uses but show/hide the text
> depending on an extra class or attribute.

[Oleg Eterevsky, 2012-07-30 12:21:10]

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/css/file_manager.css:512: .spinner {
On 2012/07/30 11:19:46, Vladislav Kaznacheev wrote:
> It might be not obvious but this CSS class is used in 3 more places in the
Files
> app which this change is likely to break. 

I've restored old styled and made spinner in FileManager independent from it.

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:3320: if
(this.directoryModel_.isSearching()) {
On 2012/07/30 11:19:46, Vladislav Kaznacheev wrote:
> I suggest keeping a single DOM element for both uses but show/hide the text
> depending on an extra class or attribute.

Done.

[Oleg Eterevsky, 2012-07-30 12:22:09]

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10834062/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:3320: if
(this.directoryModel_.isSearching()) {
On 2012/07/30 11:19:46, Vladislav Kaznacheev wrote:
> I suggest keeping a single DOM element for both uses but show/hide the text
> depending on an extra class or attribute.

Done.

[Vladislav Kaznacheev, 2012-07-30 12:24:47]

lgtm

[cpu_(ooo_6.6-7.5), 2012-07-30 21:25:28]

lgtm

http://codereview.chromium.org/10834062/diff/8006/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10834062/diff/8006/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11510: +        Searching...
suggestion
IDS_FILE_BROWSER_SEARCHING_SPINNER --> IDS_FILE_BROWSER_SEARCH_SPINNER

[jochen (gone - plz use gerrit), 2012-07-31 09:37:43]

fyi, this change broke all bots. It was landed without a single trybot run, nor
using CQ :-/