Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Unified Diff: base/json/json_parser.cc

Issue 10834060: base: Add missing "virtual" keyword and OVERRIDE to some methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_path_watcher_linux.cc ('k') | base/message_pump_glib_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_parser.cc
diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc
index 738da473272273344c248a8c9baf52fe38d9baee..0cb59ee4947e42da3e5c60f7a85c08b21ddbf17b 100644
--- a/base/json/json_parser.cc
+++ b/base/json/json_parser.cc
@@ -140,12 +140,12 @@ class JSONStringValue : public base::Value {
string_piece_(piece) {
}
- // Value:
- bool GetAsString(std::string* out_value) const OVERRIDE {
+ // Overridden from base::Value:
+ virtual bool GetAsString(std::string* out_value) const OVERRIDE {
string_piece_.CopyToString(out_value);
return true;
}
- bool GetAsString(string16* out_value) const OVERRIDE {
+ virtual bool GetAsString(string16* out_value) const OVERRIDE {
*out_value = UTF8ToUTF16(string_piece_);
return true;
}
« no previous file with comments | « base/files/file_path_watcher_linux.cc ('k') | base/message_pump_glib_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698