Issue 10834060: base: Add missing "virtual" keyword and OVERRIDE to some methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834060: base: Add missing "virtual" keyword and OVERRIDE to some methods. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base: Add missing "virtual" keyword and OVERRIDE to some methods. Found with: $ ./build/gyp_chromium -Dclang=1 -Dclang_use_chrome_plugins=1 $ ninja -C out/Debug base -k4 -j4 2>&1 | tee errors And a tweak in plugin_flags.sh BUG=115047 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149109

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	base/files/file_path_watcher_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/json/json_parser.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/message_pump_glib_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/process_util_posix.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10834060/1

8 years, 4 months ago (2012-07-30 18:25:17 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-07-30 23:35:27 UTC) #4

Try job failure for 10834060-1 (retry) (retry) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages