Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 10834057: Dead code removal: remove MetricsResponse implementation and tests (Closed)

Created:
8 years, 4 months ago by Ilya Sherman
Modified:
8 years, 4 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Visibility:
Public.

Description

Dead code removal: remove MetricsResponse implementation and tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -249 lines) Patch
D chrome/browser/metrics/metrics_response.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/metrics/metrics_response.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/metrics/metrics_response_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ilya Sherman
8 years, 4 months ago (2012-07-27 22:21:31 UTC) #1
jar (doing other things)
lgtm
8 years, 4 months ago (2012-07-30 17:12:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10834057/1
8 years, 4 months ago (2012-07-30 17:40:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 10834057-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 17:40:29 UTC) #4
Ilya Sherman
Ben, gyp changes seek rubber stamp...
8 years, 4 months ago (2012-07-30 17:42:07 UTC) #5
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-30 20:04:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10834057/1
8 years, 4 months ago (2012-07-30 21:00:50 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 00:44:09 UTC) #8
Change committed as 149092

Powered by Google App Engine
This is Rietveld 408576698