Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 10834056: Added InterfaceMirror.newInstance(). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
===================================================================
--- runtime/lib/mirrors_impl.dart (revision 10017)
+++ runtime/lib/mirrors_impl.dart (working copy)
@@ -268,15 +268,7 @@
// Walk the arguments and make sure they are legal.
for (int i = 0; i < positionalArguments.length; i++) {
var arg = positionalArguments[i];
- if (arg is Mirror) {
- if (arg is! InstanceMirror) {
- throw new MirrorException(
- 'positional argument $i ($arg) was not an InstanceMirror');
- }
- } else if (!isSimpleValue(arg)) {
- throw new MirrorException(
- 'positional argument $i ($arg) was not a simple value');
- }
+ _LocalObjectMirrorImpl._validateArgument(i, arg);
}
Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
try {
@@ -393,6 +385,30 @@
String toString() {
return "InterfaceMirror on '$simpleName'";
}
+
+ Future<InstanceMirror> newInstance(String constructorName,
+ List positionalArguments,
+ [Map<String,Dynamic> namedArguments]) {
+ if (namedArguments !== null) {
+ throw new NotImplementedException('named arguments not implemented');
+ }
+ // Walk the arguments and make sure they are legal.
+ for (int i = 0; i < positionalArguments.length; i++) {
+ var arg = positionalArguments[i];
+ _LocalObjectMirrorImpl._validateArgument(i, arg);
+ }
+ Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+ try {
+ completer.complete(
+ _invokeConstructor(this, constructorName, positionalArguments));
+ } catch (var exception) {
+ completer.completeException(exception);
+ }
+ return completer.future;
+ }
+
+ static _invokeConstructor(ref, constructorName, positionalArguments)
+ native 'LocalInterfaceMirrorImpl_invokeConstructor';
}
class _LazyLibraryMirror {
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698