Issue 10834050: Create less segments in std::string internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834050: Create less segments in std::string internals (Closed)

Created:
8 years, 4 months ago by Timur Iskhodzhanov

Modified:
8 years, 4 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Create less segments in std::string internals On my unit_tests runs, up to 25% of the memory accesses were from inside the std::string internals, which is A LOT. TBR=glider TEST=unit_tests should become faster Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148748

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/valgrind/tsan/ignores.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages