Issue 10834045: Instrument to catch corruption constructing safe-browsing filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834045: Instrument to catch corruption constructing safe-browsing filters. (Closed)

Created:
8 years, 5 months ago by Scott Hess - ex-Googler

Modified:
8 years, 4 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Instrument to catch corruption constructing safe-browsing filters. Prior instrumentation provided some evidence that memory corruption was causing inconsistencies between PrefixSet and BloomFilter results. This CL attempts to detect three types of memory corruption: - internal to the PrefixSet data structure. - internal to the BloomFilter data structure. - the input data used to construct either. BUG=71832 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150403

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+230 lines, -71 lines)			Patch
M	chrome/browser/safe_browsing/prefix_set.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database.cc	View	7 chunks	+199 lines, -70 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

I'm going OOT next week, so I don't think I'll be brave enough to check ...

8 years, 5 months ago (2012-07-27 00:33:09 UTC) #1

ramant (doing other things)

lgtm Sorry for the delay. Changes look good to me.

8 years, 4 months ago (2012-08-01 17:46:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10834045/1

8 years, 4 months ago (2012-08-07 18:40:10 UTC) #3

Change committed as 150403

Expand Messages | Collapse Messages