Script to archive profiling data collected from

Script to archive profiling data collected from
startup_test into google storage.

R=cmp

The change was committed as https://chromiumcodereview.appspot.com/10826217/

[ramant (doing other things), 2012-07-27 01:14:07]

Hi cmp and nsylvain,
  This is a prototype (or first cut) to upload profiling data to Google Storage
(we hadn't set up the GSBUCKET yet, thus wasn't able to test it). Would
appreciate your comments.

thanks
raman

[cmp, 2012-07-30 17:48:38]

https://chromiumcodereview.appspot.com/10834044/diff/2001/scripts/master/fact...
File scripts/master/factory/chromium_commands.py (right):

https://chromiumcodereview.appspot.com/10834044/diff/2001/scripts/master/fact...
scripts/master/factory/chromium_commands.py:323:
self.AddTestStep(shell.ShellCommand, 'archive profiling data', cmd, env=env)
i think instead of in this file, your change should exist in
scripts/slave/runtest.py.  from there you can just call out to your script near
the end of a test run.  then you won't have a master-side change to make to
enable this.

[cmp, 2012-07-31 23:52:03]

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py#ne...
scripts/slave/runtest.py:39: from buildbot.process.properties import
WithProperties
please remove this line, we won't need it

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py#ne...
scripts/slave/runtest.py:335: '--run-id',
WithProperties('%(got_revision)s_%(buildername)s'),
you can access these properties as:
options.build_properties['got_revision']
and:
options.build_properties['buildername']

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py#ne...
scripts/slave/runtest.py:741: upload_profiling_data(options)
this should be behind a conditional of some sort, perhaps:

if ('buildername' in options.build_properties and
    options.build_properties['buildername'] == 'XP Perf (1)' and
    ...some arg matching that matches the startup test...):

[ramant (doing other things), 2012-08-01 00:23:30]

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py#ne...
scripts/slave/runtest.py:39: from buildbot.process.properties import
WithProperties
On 2012/07/31 23:52:04, cmp wrote:
> please remove this line, we won't need it

Done.

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py#ne...
scripts/slave/runtest.py:335: '--run-id',
WithProperties('%(got_revision)s_%(buildername)s'),
On 2012/07/31 23:52:04, cmp wrote:
> you can access these properties as:
> options.build_properties['got_revision']
> and:
> options.build_properties['buildername']

Done.

http://codereview.chromium.org/10834044/diff/7001/scripts/slave/runtest.py#ne...
scripts/slave/runtest.py:741: upload_profiling_data(options)
On 2012/07/31 23:52:04, cmp wrote:
> this should be behind a conditional of some sort, perhaps:
> 
> if ('buildername' in options.build_properties and
>     options.build_properties['buildername'] == 'XP Perf (1)' and
>     ...some arg matching that matches the startup test...):

Done.

[cmp, 2012-08-07 18:15:08]

http://codereview.chromium.org/10834044/diff/10001/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

http://codereview.chromium.org/10834044/diff/10001/scripts/slave/runtest.py#n...
scripts/slave/runtest.py:325: 'archive_profiling_data.py')
is it possible to collapse this logic into archive_profiling_data.py?  so
instead of passing --profiling-data-dir, we pass --build-dir, and then that
script derives profiling_data_dir within itself?

http://codereview.chromium.org/10834044/diff/10001/scripts/slave/runtest.py#n...
scripts/slave/runtest.py:745: options.build_properties['buildername'] == 'XP
Perf (1)' and
let's collapse lines 744 and 745 into:

if (options.build_properties.get('buildername') == 'XP Perf (1)'

[ramant (doing other things), 2012-08-07 22:23:55]

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
File scripts/slave/runtest.py (right):

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
scripts/slave/runtest.py:325: 'archive_profiling_data.py')
On 2012/08/07 18:15:08, cmp wrote:
> is it possible to collapse this logic into archive_profiling_data.py?  so
> instead of passing --profiling-data-dir, we pass --build-dir, and then that
> script derives profiling_data_dir within itself?

Done. Should we move the archive_profiling_data.py to build/scripts/slave?

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
scripts/slave/runtest.py:745: options.build_properties['buildername'] == 'XP
Perf (1)' and
On 2012/08/07 18:15:08, cmp wrote:
> let's collapse lines 744 and 745 into:
> 
> if (options.build_properties.get('buildername') == 'XP Perf (1)'

Done.

[cmp, 2012-08-07 23:34:39]

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
File scripts/slave/runtest.py (right):

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
scripts/slave/runtest.py:325: 'archive_profiling_data.py')
Sure!

[ramant (doing other things), 2012-08-07 23:44:44]

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
File scripts/slave/runtest.py (right):

https://chromiumcodereview.appspot.com/10834044/diff/10001/scripts/slave/runt...
scripts/slave/runtest.py:325: 'archive_profiling_data.py')
On 2012/08/07 23:34:39, cmp wrote:
> Sure!

Done.

[cmp, 2012-08-07 23:53:16]

lgtm once you're confident it can run and runtest will be fine

[commit-bot: I haz the power, 2012-08-08 22:56:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10834044/15001

[commit-bot: I haz the power, 2012-08-08 22:56:37]

Can't process patch for file scripts/slave/archive_profiling_data.py.
Unsupported svn property format.

[commit-bot: I haz the power, 2012-08-08 23:10:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10834044/5003

[commit-bot: I haz the power, 2012-08-08 23:10:53]

Can't process patch for file scripts/slave/archive_profiling_data.py.
Unsupported svn property format.