Issue 10834041: [cros] Retail mode test should not attempt to skip OOBE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834041: [cros] Retail mode test should not attempt to skip OOBE (Closed)

Created:
8 years, 5 months ago by Nirnimesh

Modified:
8 years, 4 months ago

Reviewers:
rkc

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, bartfab (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros] Retail mode test should not attempt to skip OOBE There's no OOBE to skip in retail mode. This test broke when I switched on OOBE in test images. R=rkc@chromium.org BUG= TEST= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148923

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/test/functional/chromeos_retail_mode.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Nirnimesh

The test doesn't pass yet, but at least it gets further, and fails with: 'JSONInterfaceError: ...

8 years, 5 months ago (2012-07-26 21:32:45 UTC) #2

rkc

LGTM - there is no Oobe for a device in retail mode. On 2012/07/26 21:32:45, ...

8 years, 4 months ago (2012-07-27 20:32:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nirnimesh@chromium.org/10834041/1

8 years, 4 months ago (2012-07-30 00:49:29 UTC) #4

Change committed as 148923