Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 10834033: Move AudioDevice and AudioInputDevice to media. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and fixed a few lint issues Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_device.cc ('k') | content/renderer/media/audio_device_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_device_factory.h
===================================================================
--- content/renderer/media/audio_device_factory.h (revision 148738)
+++ content/renderer/media/audio_device_factory.h (working copy)
@@ -9,28 +9,26 @@
#include "content/common/content_export.h"
namespace media {
+class AudioInputDevice;
class AudioRendererSink;
}
-class AudioInputDevice;
-
namespace content {
// A factory for creating AudioRendererSinks. There is a global factory
// function that can be installed for the purposes of testing to provide
// a specialized AudioRendererSink class.
-// This class uses the same pattern as content::RenderViewHostFactory.
class CONTENT_EXPORT AudioDeviceFactory {
public:
// Creates an AudioRendererSink using the currently registered factory,
// or the default one if no factory is registered. Ownership of the returned
// pointer will be passed to the caller.
- static media::AudioRendererSink* NewOutputDevice();
+ static media::AudioRendererSink* NewOutputDevice();
- // TODO(henrika): Update AudioInputDevice to inherit from an interface
- // similar to AudioRendererSink, but for input. Same for the callback
- // interfaces.
- static AudioInputDevice* NewInputDevice();
+ // TODO(henrika): Update AudioInputDevice to inherit from an interface
+ // similar to AudioRendererSink, but for input. Same for the callback
+ // interfaces.
+ static media::AudioInputDevice* NewInputDevice();
protected:
AudioDeviceFactory();
@@ -41,7 +39,7 @@
// If the return value of either of these function is NULL, we fall back
// on the default implementation.
virtual media::AudioRendererSink* CreateOutputDevice() = 0;
- virtual AudioInputDevice* CreateInputDevice() = 0;
+ virtual media::AudioInputDevice* CreateInputDevice() = 0;
private:
// The current globally registered factory. This is NULL when we should
« no previous file with comments | « content/renderer/media/audio_device.cc ('k') | content/renderer/media/audio_device_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698