Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 10834031: Always set the callee's context when calling a function from optimized code. (Closed)

Created:
8 years, 5 months ago by Jakob Kummerow
Modified:
8 years, 5 months ago
Reviewers:
danno
CC:
v8-dev, fschneider
Visibility:
Public.

Description

Always set the callee's context when calling a function from optimized code. This is necessary even for recursive calls because we're sharing optimized code among closures, which could call each other and have distinct contexts. BUG=138887 TEST=mjsunit/regress/regress-crbug-138887 Committed: https://code.google.com/p/v8/source/detail?r=12201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -46 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -8 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-138887.js View 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
Danno: Please take a look. Florian: FYI.
8 years, 5 months ago (2012-07-26 12:38:40 UTC) #1
danno
8 years, 5 months ago (2012-07-26 12:46:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698