Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 10834027: Control the frequency of fileBrowserPrivate.onFileTransfersUpdated events. (Closed)

Created:
8 years, 5 months ago by kinaba
Modified:
8 years, 4 months ago
Reviewers:
zel
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Control the frequency of fileBrowserPrivate.onFileTransfersUpdated events. The update notifications were sent at every download progress and flooded the file manager UI. This patch inserts a check on frequency so that the event keeps the interval of certain (currently 1000) milliseconds. BUG=138838 TEST=manually tested copying large files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149371

Patch Set 1 #

Patch Set 2 : Move the tap to operation registry. #

Total comments: 2

Patch Set 3 : 1000msec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -21 lines) Patch
M chrome/browser/chromeos/gdata/gdata_operation_registry.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operation_registry.cc View 1 2 9 chunks +63 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operation_registry_unittest.cc View 1 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
Zel, could you take a look?
8 years, 5 months ago (2012-07-26 07:44:03 UTC) #1
kinaba
On 2012/07/26 07:44:03, kinaba wrote: > Zel, could you take a look? ping.
8 years, 4 months ago (2012-07-31 08:06:09 UTC) #2
zel
LGTM for code i would lower the progress notification frequency even more http://codereview.chromium.org/10834027/diff/6/chrome/browser/chromeos/gdata/gdata_operation_registry.cc File chrome/browser/chromeos/gdata/gdata_operation_registry.cc ...
8 years, 4 months ago (2012-07-31 15:24:49 UTC) #3
kinaba
http://codereview.chromium.org/10834027/diff/6/chrome/browser/chromeos/gdata/gdata_operation_registry.cc File chrome/browser/chromeos/gdata/gdata_operation_registry.cc (right): http://codereview.chromium.org/10834027/diff/6/chrome/browser/chromeos/gdata/gdata_operation_registry.cc#newcode14 chrome/browser/chromeos/gdata/gdata_operation_registry.cc:14: const int64 kNotificationFrequencyInMilliseconds = 150; On 2012/07/31 15:24:50, zel ...
8 years, 4 months ago (2012-08-01 02:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10834027/7008
8 years, 4 months ago (2012-08-01 02:29:02 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 04:01:15 UTC) #6
Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

Powered by Google App Engine
This is Rietveld 408576698