Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 10834021: Outsource FileSystemOperationContext from LocalFileSystemOperation (Closed)

Created:
8 years, 5 months ago by tzik
Modified:
8 years, 5 months ago
Reviewers:
kinuko
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Outsource FileSystemOperationContext from LocalFileSystemOperation BUG=None TEST=existing test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148512

Patch Set 1 #

Patch Set 2 : build fix #

Patch Set 3 : build fix again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -30 lines) Patch
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/fileapi/local_file_system_operation.h View 2 chunks +5 lines, -7 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 16 chunks +20 lines, -18 lines 0 comments Download
webkit/fileapi/local_file_system_test_helper.cc View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
8 years, 5 months ago (2012-07-26 00:15:49 UTC) #1
kinuko
lgtm if tests pass
8 years, 5 months ago (2012-07-26 00:21:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10834021/1
8 years, 5 months ago (2012-07-26 00:23:44 UTC) #3
commit-bot: I haz the power
Try job failure for 10834021-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 00:50:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10834021/11001
8 years, 5 months ago (2012-07-26 00:56:13 UTC) #5
commit-bot: I haz the power
Try job failure for 10834021-11001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 01:21:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10834021/7006
8 years, 5 months ago (2012-07-26 02:33:33 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 04:06:22 UTC) #8
Change committed as 148512

Powered by Google App Engine
This is Rietveld 408576698