Issue 10834016: Alternative: access the WebContentsView directly without an interface method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834016: Alternative: access the WebContentsView directly without an interface method. (Closed)

Created:
8 years, 5 months ago by jeremya

Modified:
8 years, 4 months ago

Reviewers:

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jeremya+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Alternative: access the WebContentsView directly without an interface method. Alt. implementation of http://codereview.chromium.org/10824004/

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -3 lines)			Patch
M	chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm	View	2 chunks	+41 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_mac.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_mac.mm	View	2 chunks	+5 lines, -1 line	0 comments	Download