Refactor of Histogram related code

base/metrics/bucket_ranges.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/bucket_ranges.h"
 
 #include <cmath>
 
 #include "base/logging.h"
 
 namespace base {
 
 // Static table of checksums for all possible 8 bit bytes.
-static const uint32 kCrcTable[256] = { 0x0, 0x77073096L, 0xee0e612cL,
+const uint32 kCrcTable[256] = { 0x0, 0x77073096L, 0xee0e612cL,
 0x990951baL, 0x76dc419L, 0x706af48fL, 0xe963a535L, 0x9e6495a3L, 0xedb8832L,
 0x79dcb8a4L, 0xe0d5e91eL, 0x97d2d988L, 0x9b64c2bL, 0x7eb17cbdL, 0xe7b82d07L,
 0x90bf1d91L, 0x1db71064L, 0x6ab020f2L, 0xf3b97148L, 0x84be41deL, 0x1adad47dL,
 0x6ddde4ebL, 0xf4d4b551L, 0x83d385c7L, 0x136c9856L, 0x646ba8c0L, 0xfd62f97aL,
 0x8a65c9ecL, 0x14015c4fL, 0x63066cd9L, 0xfa0f3d63L, 0x8d080df5L, 0x3b6e20c8L,
 0x4c69105eL, 0xd56041e4L, 0xa2677172L, 0x3c03e4d1L, 0x4b04d447L, 0xd20d85fdL,
 0xa50ab56bL, 0x35b5a8faL, 0x42b2986cL, 0xdbbbc9d6L, 0xacbcf940L, 0x32d86ce3L,
 0x45df5c75L, 0xdcd60dcfL, 0xabd13d59L, 0x26d930acL, 0x51de003aL, 0xc8d75180L,
 0xbfd06116L, 0x21b4f4b5L, 0x56b3c423L, 0xcfba9599L, 0xb8bda50fL, 0x2802b89eL,
 0x5f058808L, 0xc60cd9b2L, 0xb10be924L, 0x2f6f7c87L, 0x58684c11L, 0xc1611dabL,
@@ skipping 75 matching lines @@
       checksum_(0) {}
 
 BucketRanges::~BucketRanges() {}
 
 void BucketRanges::set_range(size_t i, HistogramBase::Sample value) {
   DCHECK_LT(i, ranges_.size());
   DCHECK_GE(value, 0);
   ranges_[i] = value;
 }
 
-uint32 BucketRanges::CalculateChecksum() {
+uint32 BucketRanges::CalculateChecksum() const {
   // Seed checksum.
   uint32 checksum = static_cast<uint32>(ranges_.size());
 
   for (size_t index = 0; index < ranges_.size(); ++index)
     checksum = Crc32(checksum, ranges_[index]);
   return checksum;
 }
 
-bool BucketRanges::HasValidChecksum() {
+bool BucketRanges::HasValidChecksum() const {
   return CalculateChecksum() == checksum_;
 }
 
 void BucketRanges::ResetChecksum() {
   checksum_ = CalculateChecksum();
 }
 
 bool BucketRanges::Equals(const BucketRanges* other) const {
   if (checksum_ != other->checksum_)
     return false;
   if (ranges_.size() != other->ranges_.size())
     return false;
   for (size_t index = 0; index < ranges_.size(); ++index) {
     if (ranges_[index] != other->ranges_[index])
       return false;
   }
   return true;
 }
 
 }  // namespace base