Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: chrome/test/webdriver/commands/command.h

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/automation_json_requests.cc ('k') | chrome/test/webdriver/commands/command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/command.h
diff --git a/chrome/test/webdriver/commands/command.h b/chrome/test/webdriver/commands/command.h
index 97f0259e9fe1c0bb92021974ea437cae6e8448f6..ba95201d7693336992491de35415fa09b330c9cf 100644
--- a/chrome/test/webdriver/commands/command.h
+++ b/chrome/test/webdriver/commands/command.h
@@ -95,11 +95,11 @@ class Command {
// Provides the command parameter with the given |key| as a Dictionary.
// Returns false if there is no such parameter, or if it is not a Dictionary.
bool GetDictionaryParameter(const std::string& key,
- DictionaryValue** out) const;
+ const DictionaryValue** out) const;
// Provides the command parameter with the given |key| as a list. Returns
// false if there is no such parameter, or if it is not a list.
- bool GetListParameter(const std::string& key, ListValue** out) const;
+ bool GetListParameter(const std::string& key, const ListValue** out) const;
const std::vector<std::string> path_segments_;
const scoped_ptr<const DictionaryValue> parameters_;
« no previous file with comments | « chrome/test/automation/automation_json_requests.cc ('k') | chrome/test/webdriver/commands/command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698