chrome/browser/metrics/metrics_log.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index 2379dc68c23e5114b33bc72f5fd8b86a841f75ac..69fd3f8a02b456c3121e4526d17c538393c14058 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -819,7 +819,7 @@ void MetricsLog::WriteAllProfilesMetrics(

i != all_profiles_metrics.end_keys(); ++i) {

const std::string& key_name = *i;

if (key_name.compare(0, profile_prefix.size(), profile_prefix) == 0) {

- DictionaryValue* profile;

+ const DictionaryValue* profile;

if (all_profiles_metrics.GetDictionaryWithoutPathExpansion(key_name,

&profile))

WriteProfileMetrics(key_name.substr(profile_prefix.size()), *profile);

@@ -833,7 +833,7 @@ void MetricsLog::WriteProfileMetrics(const std::string& profileidhash,

WriteAttribute("profileidhash", profileidhash);

for (DictionaryValue::key_iterator i = profile_metrics.begin_keys();

i != profile_metrics.end_keys(); ++i) {

- Value* value;

+ const Value* value;

if (profile_metrics.GetWithoutPathExpansion(*i, &value)) {

DCHECK(*i != "id");

switch (value->GetType()) {