Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/chromeos/gdata/gdata_wapi_parser.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_wapi_parser.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc b/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc
index 79ac073062b63a2c0eeaf61b0946528d763508bf..f604f3559bdeb91995bfc45d122d52ac06869d69 100644
--- a/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc
+++ b/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc
@@ -696,7 +696,7 @@ void DocumentEntry::FillRemainingFields() {
DocumentEntry* DocumentEntry::ExtractAndParse(
const base::Value& value) {
const base::DictionaryValue* as_dict = NULL;
- base::DictionaryValue* entry_dict = NULL;
+ const base::DictionaryValue* entry_dict = NULL;
if (value.GetAsDictionary(&as_dict) &&
as_dict->GetDictionary(kEntryField, &entry_dict)) {
return DocumentEntry::CreateFrom(*entry_dict);
@@ -859,7 +859,7 @@ bool DocumentFeed::Parse(const base::Value& value) {
scoped_ptr<DocumentFeed> DocumentFeed::ExtractAndParse(
const base::Value& value) {
const base::DictionaryValue* as_dict = NULL;
- base::DictionaryValue* feed_dict = NULL;
+ const base::DictionaryValue* feed_dict = NULL;
if (value.GetAsDictionary(&as_dict) &&
as_dict->GetDictionary(kFeedField, &feed_dict)) {
return DocumentFeed::CreateFrom(*feed_dict);
@@ -1007,7 +1007,7 @@ scoped_ptr<AccountMetadataFeed> AccountMetadataFeed::CreateFrom(
const base::Value& value) {
scoped_ptr<AccountMetadataFeed> feed(new AccountMetadataFeed());
const base::DictionaryValue* dictionary = NULL;
- base::Value* entry = NULL;
+ const base::Value* entry = NULL;
if (!value.GetAsDictionary(&dictionary) ||
!dictionary->Get(kEntryField, &entry) ||
!feed->Parse(*entry)) {
« no previous file with comments | « chrome/browser/chromeos/cros/onc_network_parser.cc ('k') | chrome/browser/chromeos/login/user_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698