Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 10833071: Renaming the 'keybinding' permission to 'commands'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 skip.insert(APIPermission::kWebRequestBlocking); 568 skip.insert(APIPermission::kWebRequestBlocking);
569 skip.insert(APIPermission::kDeclarativeWebRequest); 569 skip.insert(APIPermission::kDeclarativeWebRequest);
570 570
571 571
572 // This permission requires explicit user action (context menu handler) 572 // This permission requires explicit user action (context menu handler)
573 // so we won't prompt for it for now. 573 // so we won't prompt for it for now.
574 skip.insert(APIPermission::kFileBrowserHandler); 574 skip.insert(APIPermission::kFileBrowserHandler);
575 575
576 // This permission requires explicit user action (shortcut) so we don't 576 // This permission requires explicit user action (shortcut) so we don't
577 // prompt for it. 577 // prompt for it.
578 skip.insert(APIPermission::kKeybinding); 578 skip.insert(APIPermission::kCommands);
579 579
580 // These permissions require explicit user action (configuration dialog) 580 // These permissions require explicit user action (configuration dialog)
581 // so we don't prompt for them at install time. 581 // so we don't prompt for them at install time.
582 skip.insert(APIPermission::kMediaGalleries); 582 skip.insert(APIPermission::kMediaGalleries);
583 skip.insert(APIPermission::kMediaGalleriesRead); 583 skip.insert(APIPermission::kMediaGalleriesRead);
584 584
585 // If you've turned on the experimental command-line flag, we don't need 585 // If you've turned on the experimental command-line flag, we don't need
586 // to warn you further. 586 // to warn you further.
587 skip.insert(APIPermission::kExperimental); 587 skip.insert(APIPermission::kExperimental);
588 588
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 apis.insert(APIPermission::kWebRequest); 1134 apis.insert(APIPermission::kWebRequest);
1135 apis.insert(APIPermission::kFileBrowserHandler); 1135 apis.insert(APIPermission::kFileBrowserHandler);
1136 EXPECT_EQ(2U, apis.size()); 1136 EXPECT_EQ(2U, apis.size());
1137 1137
1138 scoped_refptr<PermissionSet> perm_set; 1138 scoped_refptr<PermissionSet> perm_set;
1139 perm_set = new PermissionSet(apis, empty_extent, empty_extent); 1139 perm_set = new PermissionSet(apis, empty_extent, empty_extent);
1140 EXPECT_EQ(4U, perm_set->apis().size()); 1140 EXPECT_EQ(4U, perm_set->apis().size());
1141 } 1141 }
1142 1142
1143 } // namespace extensions 1143 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698