Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10833061: Rolling libjingle revison r163. (Closed)

Created:
8 years, 4 months ago by Mallinath (Gone from Chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Rolling libjingle revison r163.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 14

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M content/renderer/media/peer_connection_handler_jsep.cc View 1 2 3 4 5 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mallinath (Gone from Chromium)
8 years, 4 months ago (2012-07-30 18:01:08 UTC) #1
Ronghua Wu (Left Chromium)
Few minor comments, otherwise lg. https://chromiumcodereview.appspot.com/10833061/diff/1017/content/renderer/media/media_stream_dependency_factory.h File content/renderer/media/media_stream_dependency_factory.h (right): https://chromiumcodereview.appspot.com/10833061/diff/1017/content/renderer/media/media_stream_dependency_factory.h#newcode80 content/renderer/media/media_stream_dependency_factory.h:80: int m_line_index, use sdp_mid ...
8 years, 4 months ago (2012-07-30 18:09:10 UTC) #2
wjia(left Chromium)
http://codereview.chromium.org/10833061/diff/1017/content/renderer/media/media_stream_center.cc File content/renderer/media/media_stream_center.cc (right): http://codereview.chromium.org/10833061/diff/1017/content/renderer/media/media_stream_center.cc#newcode10 content/renderer/media/media_stream_center.cc:10: #include "base/string_number_conversions.h" file order.
8 years, 4 months ago (2012-07-30 18:19:10 UTC) #3
Mallinath (Gone from Chromium)
http://codereview.chromium.org/10833061/diff/1017/content/renderer/media/media_stream_center.cc File content/renderer/media/media_stream_center.cc (right): http://codereview.chromium.org/10833061/diff/1017/content/renderer/media/media_stream_center.cc#newcode10 content/renderer/media/media_stream_center.cc:10: #include "base/string_number_conversions.h" On 2012/07/30 18:19:10, wjia wrote: > file ...
8 years, 4 months ago (2012-07-30 18:42:08 UTC) #4
Ronghua Wu (Left Chromium)
lgtm http://codereview.chromium.org/10833061/diff/14001/content/renderer/media/peer_connection_handler_jsep.cc File content/renderer/media/peer_connection_handler_jsep.cc (right): http://codereview.chromium.org/10833061/diff/14001/content/renderer/media/peer_connection_handler_jsep.cc#newcode163 content/renderer/media/peer_connection_handler_jsep.cc:163: // TODO: Use sdp_mid when its available, for ...
8 years, 4 months ago (2012-07-30 18:58:59 UTC) #5
wjia(left Chromium)
lgtm
8 years, 4 months ago (2012-07-30 19:02:09 UTC) #6
Mallinath (Gone from Chromium)
http://codereview.chromium.org/10833061/diff/14001/content/renderer/media/peer_connection_handler_jsep.cc File content/renderer/media/peer_connection_handler_jsep.cc (right): http://codereview.chromium.org/10833061/diff/14001/content/renderer/media/peer_connection_handler_jsep.cc#newcode163 content/renderer/media/peer_connection_handler_jsep.cc:163: // TODO: Use sdp_mid when its available, for now ...
8 years, 4 months ago (2012-07-30 19:11:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/10833061/14004
8 years, 4 months ago (2012-07-30 19:11:39 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 20:35:56 UTC) #9 
Change committed as 149013

Powered by Google App Engine
This is Rietveld 408576698