Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 10833059: SPDY - update the comment to have "status" for SPDY_SESSION_GOAWAY (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

SPDY - update the comment to have "status" for SPDY_SESSION_GOAWAY net log event. https://src.chromium.org/viewvc/chrome?view=rev&revision=148115 is the original CL that had the logging. BUG=133995 R=willchan TEST=network unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148873

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/base/net_log_event_type_list.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
Hi willchan, Missed checking of this file (small update to the comment). thanks, raman
8 years, 4 months ago (2012-07-27 22:12:07 UTC) #1
eroman
LGTM nit: typo in the CL description "oroginal CL"
8 years, 4 months ago (2012-07-27 22:54:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10833059/1
8 years, 4 months ago (2012-07-27 23:15:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10833059/4003
8 years, 4 months ago (2012-07-28 00:43:15 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-28 02:21:35 UTC) #5
Change committed as 148873

Powered by Google App Engine
This is Rietveld 408576698