Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 10833052: Removing duplicate IsHidden function from RWHI. (Closed)

Created:
8 years, 4 months ago by mmocny
Modified:
8 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Removing duplicate IsHidden function from RWHI. is_hidden() was already added to RWHI recently and they duplicate exact functionality. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149070

Patch Set 1 #

Patch Set 2 : Fixing merge conflict. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mmocny
8 years, 4 months ago (2012-07-27 14:56:25 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-27 17:17:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/10833052/1
8 years, 4 months ago (2012-07-27 17:23:54 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/render_widget_host_impl.h: While running patch -p1 --forward --force; patching file content/browser/renderer_host/render_widget_host_impl.h ...
8 years, 4 months ago (2012-07-27 17:23:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/10833052/6001
8 years, 4 months ago (2012-07-27 17:42:29 UTC) #5
commit-bot: I haz the power
Try job failure for 10833052-6001 on linux_chromeos for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=29330 Step "update" is always ...
8 years, 4 months ago (2012-07-27 18:32:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/10833052/8003
8 years, 4 months ago (2012-07-30 20:21:57 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 23:18:17 UTC) #8
Change committed as 149070

Powered by Google App Engine
This is Rietveld 408576698