sandbox/linux/seccomp-bpf/Makefile - Issue 10833044: Refactored ErrorCode into it's own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/Makefile

Issue 10833044: Refactored ErrorCode into it's own class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased after we moved the unittest framework into its own CL Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/seccomp-bpf/Makefile

diff --git a/sandbox/linux/seccomp-bpf/Makefile b/sandbox/linux/seccomp-bpf/Makefile

index 57531244e82cdf7632310b66298e3f0a23a554a1..a8a2ca3110511701710f455738837f433bd36e31 100644

--- a/sandbox/linux/seccomp-bpf/Makefile

+++ b/sandbox/linux/seccomp-bpf/Makefile

@@ -1,8 +1,8 @@

-CFLAGS = -g -O3 -Wall -Werror -Wextra -Wno-missing-field-initializers -fPIC -I.

-CPPFLAGS = -D_GNU_SOURCE -DSECCOMP_BPF_STANDALONE -iquote ../../..

-LDFLAGS = -g -lpthread

+DEF_CFLAGS = -g -O3 -Wall -Werror -Wextra -Wno-missing-field-initializers -fPIC -I.

+DEF_CPPFLAGS = -D_GNU_SOURCE -DSECCOMP_BPF_STANDALONE -DSECCOMP_BPF_VALGRIND_HACKS -include valgrind/valgrind.h -iquote ../../..

jln (very slow on Chromium) 2012/08/31 01:16:00 80 columns in this file would be nice. But up to y

+DEF_LDFLAGS = -g -lpthread

DEPFLAGS = -MMD -MF .$@.d

-MODS := demo sandbox_bpf die util verifier

+MODS := demo sandbox_bpf die errorcode util verifier

OBJS64 := $(shell echo ${MODS} | xargs -n 1 | sed -e 's/$$/.o64/')

OBJS32 := $(shell echo ${MODS} | xargs -n 1 | sed -e 's/$$/.o32/')

ALL_OBJS = $(OBJS32) $(OBJS64)

@@ -20,11 +20,11 @@ clean:

-include $(DEP_FILES)

demo32: ${OBJS32}

- ${CXX} -m32 -o $@ $+ ${LDFLAGS}

+ ${CXX} -m32 -o $@ $+ ${DEF_LDFLAGS} ${LDFLAGS}

demo64: ${OBJS64}

- ${CXX} -m64 -o $@ $+ ${LDFLAGS}

+ ${CXX} -m64 -o $@ $+ ${DEF_LDFLAGS} ${LDFLAGS}

.cc.o32:

- ${CXX} -m32 ${CFLAGS} ${CPPFLAGS} ${DEPFLAGS} -c -o $@ $<

+ ${CXX} -m32 ${DEF_CFLAGS} ${DEF_CPPFLAGS} ${CFLAGS} ${CPPFLAGS} ${DEPFLAGS} -c -o $@ $<

.cc.o64:

- ${CXX} -m64 ${CFLAGS} ${CPPFLAGS} ${DEPFLAGS} -c -o $@ $<

+ ${CXX} -m64 ${DEF_CFLAGS} ${DEF_CPPFLAGS} ${CFLAGS} ${CPPFLAGS} ${DEPFLAGS} -c -o $@ $<