sandbox/linux/seccomp-bpf/verifier.cc - Issue 10833044: Refactored ErrorCode into it's own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/verifier.cc

Issue 10833044: Refactored ErrorCode into it's own class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added unittest (and new framework to make this possible) Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/seccomp-bpf/verifier.cc

diff --git a/sandbox/linux/seccomp-bpf/verifier.cc b/sandbox/linux/seccomp-bpf/verifier.cc

index 52a385eeb6dc4c86980cb92ebcf1923c9f0c6207..882e96f6e6133757f5369905da7084350f8cb4f4 100644

--- a/sandbox/linux/seccomp-bpf/verifier.cc

+++ b/sandbox/linux/seccomp-bpf/verifier.cc

@@ -36,11 +36,11 @@ bool Verifier::verifyBPF(const std::vector<struct sock_filter>& program,

#endif

struct arch_seccomp_data data = { sysnum, SECCOMP_ARCH };

- Sandbox::ErrorCode code = evaluateSyscall(sysnum);

+ ErrorCode code = evaluateSyscall(sysnum);

uint32_t computedRet = evaluateBPF(program, data, err);

if (*err) {

return false;

- } else if (computedRet != code) {

+ } else if (computedRet != code.err()) {

*err = "Exit code from BPF program doesn't match";

return false;

}