Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 10833041: Change web notifications to show at the top of the list, clean up layout. (Closed)

Created:
8 years, 5 months ago by stevenjb
Modified:
8 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Change web notifications to show at the top of the list, clean up layout. This partially addresses http://code.google.com/p/chromium/issues/detail?id=137155 by placing new notifications at the front of the list and rendering newer notifications first. This also greatly simplifes the layout code for web notifications. It also fixes a bug where notifications were not getting redrawn correctly when the shelf alignment was changed. BUG=137155 TEST=New web notifications should show up at the top of the list. The list should size correctly as new notifications arrive, scrolling when the max size is reached, showing up to 99 notifications in the list. R=sadrul@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
M ash/system/tray/system_tray.cc View 2 chunks +8 lines, -1 line 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 10 chunks +23 lines, -40 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
Ready for review. Please take a quick look if you can, I would like to ...
8 years, 5 months ago (2012-07-26 22:59:50 UTC) #1
sadrul
LGTM (sorry about the delay. fell through the cracks)
8 years, 4 months ago (2012-07-27 20:36:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10833041/1
8 years, 4 months ago (2012-07-30 17:21:49 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 18:54:20 UTC) #4
Change committed as 148991

Powered by Google App Engine
This is Rietveld 408576698