Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10833038: Changed a DCHECK() that checked two conditions two two DCHECK()s that check one condition each. (Closed)

Created:
8 years, 5 months ago by Kyle Horimoto
Modified:
8 years, 4 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, tfarina, dcheng
Visibility:
Public.

Description

Changed a DCHECK() that checked two conditions two two DCHECK()s that check one condition each. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Kyle Horimoto
8 years, 5 months ago (2012-07-26 17:48:36 UTC) #1
James Hawkins
lgtm
8 years, 5 months ago (2012-07-26 17:50:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10833038/1
8 years, 5 months ago (2012-07-26 17:54:01 UTC) #3
commit-bot: I haz the power
Try job failure for 10833038-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-07-26 23:09:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10833038/1
8 years, 5 months ago (2012-07-26 23:54:50 UTC) #5
commit-bot: I haz the power
Try job failure for 10833038-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-27 02:15:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10833038/1
8 years, 4 months ago (2012-07-27 03:08:30 UTC) #7
commit-bot: I haz the power
Try job failure for 10833038-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-27 04:00:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10833038/1
8 years, 4 months ago (2012-07-27 18:01:58 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 20:46:40 UTC) #10
Change committed as 148799

Powered by Google App Engine
This is Rietveld 408576698