lib/dom/scripts/systemnative.py - Issue 10833035: Quick fix to make bbs green.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10833035: Quick fix to make bbs green. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index 7f56eb9a41735753284b2681a738584d73c21de2..8a8874ace76448b040f99e81878ffc43dc39fcec 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -805,7 +805,7 @@ class NativeImplementationGenerator(systembase.BaseGenerator):

cpp_arguments.append(type_info.emit_to_native(

body_emitter,

argument,

- IsOptional(argument) and not self._IsArgumentOptionalInWebCore(node, argument),

+ (IsOptional(argument) and not self._IsArgumentOptionalInWebCore(node, argument)) or (argument.ext_attrs.get('Optional') == 'DefaultIsNullString'),

# TODO(antonm): all IDs should be renamed when database is generated.

# That will allow to get rid of argument_name argument altogether.

DartDomNameOfAttribute(argument),

« no previous file with comments | « no previous file | no next file » | no next file with comments »