Issue 10833033: Set LastAdded to kNoneAdded in RawCopy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833033: Set LastAdded to kNoneAdded in RawCopy. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Set LastAdded to kNoneAdded in RawCopy. This ensures it is properly initialized if no descriptors are later set. Committed: https://code.google.com/p/v8/source/detail?r=12202

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -33 lines)			Patch
M	src/heap.cc	View	2 chunks	+17 lines, -22 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+7 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

PTAL. The meat of the change is adding SetLastAdded(kNoneAdded) to src/objects.cc:4817. This ensures that, in ...

8 years, 5 months ago (2012-07-26 10:53:51 UTC) #1

danno

8 years, 5 months ago (2012-07-26 13:47:40 UTC) #3

Actually, lgtm. land it first to see if it helps the layout tests, and if it
does, we can re-push.