Issue 10833030: Prevent multile DoPoll() calls from being simultaneously pending

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833030: Prevent multile DoPoll() calls from being simultaneously pending (Closed)

Created:
8 years, 5 months ago by jar (doing other things)

Modified:
8 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Prevent multile DoPoll() calls from being simultaneously pending r=scottmg BUG=139084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148631

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	content/browser/gamepad/gamepad_provider.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	content/browser/gamepad/gamepad_provider.cc	View		4 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm Note that the delay is 16ms, so it ought to be on the order ...

8 years, 5 months ago (2012-07-26 16:02:08 UTC) #2

jar (doing other things)

<oops> my mistake. I spotted chrome/src/content/browser/device_orientation/provider_impl.h which also had a kDesiredSamplingIntervalMs. You are correct... it ...

8 years, 5 months ago (2012-07-26 22:13:58 UTC) #3

scottmg

8 years, 5 months ago (2012-07-26 22:25:26 UTC) #4

On 2012/07/26 22:13:58, jar wrote:
> <oops>  my mistake.  I spotted
> chrome/src/content/browser/device_orientation/provider_impl.h
> which also had a kDesiredSamplingIntervalMs.
> 
> You are correct... it is supposed to be 16ms, when I look in the "right" file:
> 
> chrome/src/content/browser/gamepad/gamepad_provider.h

Ah, perhaps we should rename that kDesiredGamepadSamplingIntervalMs to be more
clear.

> 
> Sorry about my confusion.
> 
> 
> On 2012/07/26 16:02:08, scottmg wrote:
> > lgtm
> > 
> > Note that the delay is 16ms, so it ought to be on the order of 60/second
when
> > running, not 10 (per bug).

Expand Messages | Collapse Messages