Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 10833028: Make audio build on the Mac OS X 10.7 (Closed)

Created:
8 years, 4 months ago by abarth-chromium
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Make audio build on the Mac OS X 10.7 BUG=136844

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Make audio build on the Mac OS X 10.7 #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/mac/audio_low_latency_output_mac.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/mac/audio_output_mac.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
8 years, 4 months ago (2012-07-26 01:41:52 UTC) #1
Nico
BUG=136844 (I'm not an OWNER here) https://chromiumcodereview.appspot.com/10833028/diff/1/audio/mac/audio_low_latency_input_mac.h File audio/mac/audio_low_latency_input_mac.h (right): https://chromiumcodereview.appspot.com/10833028/diff/1/audio/mac/audio_low_latency_input_mac.h#newcode40 audio/mac/audio_low_latency_input_mac.h:40: #include <CoreAudio/CoreAudioTypes.h> Usually, ...
8 years, 4 months ago (2012-07-26 01:44:37 UTC) #2
abarth-chromium
Now with more bigger headers.
8 years, 4 months ago (2012-07-26 01:50:54 UTC) #3
abarth-chromium
Looks like tommi is the relevant OWNER.
8 years, 4 months ago (2012-07-26 01:51:26 UTC) #4
Nico
lgtm with below addressed. I think this is small enough that you can add `TBR=tommi` ...
8 years, 4 months ago (2012-07-26 02:40:45 UTC) #5
tommi (sloooow) - chröme
lgtm with Nico's suggestions.
8 years, 4 months ago (2012-07-26 08:02:24 UTC) #6
abarth-chromium
Thanks tommi. Will do.
8 years, 4 months ago (2012-07-26 08:26:54 UTC) #7
abarth-chromium
Make audio build on the Mac OS X 10.7 BUG=136844
8 years, 4 months ago (2012-07-26 08:39:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/10833028/13001
8 years, 4 months ago (2012-07-26 08:39:52 UTC) #9
commit-bot: I haz the power
Failed to apply patch for media/media/audio/mac/audio_low_latency_input_mac.h: While running patch -p0 --forward --force; A media/media A ...
8 years, 4 months ago (2012-07-26 08:39:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/10833028/3003
8 years, 4 months ago (2012-07-26 08:43:15 UTC) #11
commit-bot: I haz the power
Failed to apply patch for media/media/audio/mac/audio_low_latency_input_mac.h: While running patch -p0 --forward --force; A media/media A ...
8 years, 4 months ago (2012-07-26 08:43:19 UTC) #12
abarth-chromium
8 years, 4 months ago (2012-07-26 08:51:59 UTC) #13
As far as I can tell this CL is corrupt beyond repair because the base URL is
wrong and I don't see a way to change it.  The patch will be landed from
https://chromiumcodereview.appspot.com/10823033

Powered by Google App Engine
This is Rietveld 408576698