Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 10833027: aura: apply brightness filter last to improve perf (Closed)

Created:
8 years, 5 months ago by piman
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer
Visibility:
Public.

Description

aura: apply brightness filter last to improve perf https://bugs.webkit.org/show_bug.cgi?id=92059 adds an optimization on color matrix filters so that they can be combined in a single pass as long as the resulting colors don't need to be clamped. Brightness needs clamping, so it should go last. This also fixes an uninitialized value that made us stick a grayscale filter randomly on layers. BUG=138645 TEST=new startup animation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148837

Patch Set 1 #

Patch Set 2 : Also fix uninitialized value #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ui/compositor/layer.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
piman
8 years, 5 months ago (2012-07-26 01:29:13 UTC) #1
Mr4D (OOO till 08-26)
lgtm https://chromiumcodereview.appspot.com/10833027/diff/2001/ui/compositor/layer.cc File ui/compositor/layer.cc (right): https://chromiumcodereview.appspot.com/10833027/diff/2001/ui/compositor/layer.cc#newcode304 ui/compositor/layer.cc:304: } Good old times... I remember when I ...
8 years, 5 months ago (2012-07-26 13:57:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10833027/2001
8 years, 5 months ago (2012-07-26 17:06:18 UTC) #3
commit-bot: I haz the power
Try job failure for 10833027-2001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 18:28:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10833027/2001
8 years, 5 months ago (2012-07-26 19:31:20 UTC) #5
commit-bot: I haz the power
Try job failure for 10833027-2001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-26 23:45:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10833027/2001
8 years, 5 months ago (2012-07-26 23:57:00 UTC) #7
commit-bot: I haz the power
Try job failure for 10833027-2001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-27 03:03:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10833027/2001
8 years, 5 months ago (2012-07-27 03:26:34 UTC) #9
commit-bot: I haz the power
Try job failure for 10833027-2001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-27 03:54:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10833027/3007
8 years, 4 months ago (2012-07-27 21:17:36 UTC) #11
commit-bot: I haz the power
Change committed as 148837
8 years, 4 months ago (2012-07-27 22:42:47 UTC) #12
Nikita (slow)
8 years, 4 months ago (2012-07-28 01:49:54 UTC) #13
https://chromiumcodereview.appspot.com/10833027/diff/2001/ui/compositor/layer.cc
File ui/compositor/layer.cc (right):

https://chromiumcodereview.appspot.com/10833027/diff/2001/ui/compositor/layer...
ui/compositor/layer.cc:81: layer_grayscale_(0.0f),
Oh, sorry for this one.

Powered by Google App Engine
This is Rietveld 408576698