Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 10833026: Allow a tad more race-induced histogram errors (Closed)

Created:
8 years, 5 months ago by jar (doing other things)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org
Visibility:
Public.

Description

Allow a tad more race-induced histogram errors When the sum of the buckets is "significantly" different from a second counter, which is incremented when any bucket is bumped, then we declare the histogram to be potentially "spammed." The limit was a difference by 1, but examination of the UMA uploads shows that for some histograms, this can grow larger. This CL increases the threshold from "as much as 1 away" to "as much as 5 away." r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/metrics/histogram.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
8 years, 4 months ago (2012-07-30 17:14:41 UTC) #1
ramant (doing other things)
lgtm
8 years, 4 months ago (2012-07-30 17:32:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/10833026/1
8 years, 4 months ago (2012-07-30 17:46:16 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 19:31:13 UTC) #4
Change committed as 148997

Powered by Google App Engine
This is Rietveld 408576698