Issue 10833024: Fix syntax highlighting in JSON Schema Compiler's preview server: don't crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833024: Fix syntax highlighting in JSON Schema Compiler's preview server: don't crash (Closed)

Created:
8 years, 5 months ago by not at google - send to devlin

Modified:
8 years, 5 months ago

Reviewers:
Matt Tytel

CC:
chromium-reviews, pam+watch_chromium.org, benwells, koz (OOO until 15th September)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix syntax highlighting in JSON Schema Compiler's preview server: don't crash if Pygments isn't installed, and escape HTML (especially obvious with generics) when syntax highlighting is turned off. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148482

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
M	tools/json_schema_compiler/highlighters/none_highlighter.py	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tools/json_schema_compiler/highlighters/pygments_highlighter.py	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	tools/json_schema_compiler/previewserver.py	View		1 chunk	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

Quick one that's been bugging me for a while.

8 years, 5 months ago (2012-07-25 23:56:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10833024/2001

8 years, 5 months ago (2012-07-26 00:24:01 UTC) #3

Change committed as 148482

Expand Messages | Collapse Messages