Fix gcc 4.7 building problems - cont 2.

Fix gcc 4.7 building problems - cont 2.

(The gcc 4.7 building problems keep popping up as I sync the repo, so there are several "fix gcc 4.7 .." cls.)

Fixes include -
- added static_cast for narrowing conversion in simple(short)
  initiliazation lists
- added explicit <unistd.h> inclusion

BUG=None
TEST=Built successfully using GCC-4.7 under linux and under chromeos chroot.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148519

[Han, 2012-07-25 20:29:09]

Hi Adam, Julien and Bernhard, could you take a look at the following fix for gcc
4.7 builds, thanks!

agl - net/*
markus - sandbox/*
bauerb - webkit/plugin/npapi/*


Regards,
-Han

[Bernhard Bauer, 2012-07-25 20:30:57]

webkit/plugins/npapi LGTM.

[agl, 2012-07-25 20:32:34]

https://chromiumcodereview.appspot.com/10833017/diff/1/net/dns/dns_config_ser...
File net/dns/dns_config_service.cc (right):

https://chromiumcodereview.appspot.com/10833017/diff/1/net/dns/dns_config_ser...
net/dns/dns_config_service.cc:19: #define _C_(x) static_cast<unsigned char>(x)
_C_ is an odd name for a macro. How about U8?

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
File webkit/plugins/npapi/test/plugin_execute_stream_javascript.cc (right):

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
webkit/plugins/npapi/test/plugin_execute_stream_javascript.cc:40:
javascript.append(static_cast<char*>(buffer), len);
Not your fault, but while you're in the area: add a check that
javascript.length() == static_cast<uint32_t>(javascript.length()) and return an
error otherwise.

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
File webkit/plugins/npapi/test/plugin_windowless_test.cc (right):

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
webkit/plugins/npapi/test/plugin_windowless_test.cc:137: NPString script_string
= { script_url.c_str(),
ditto.

[Markus (顧孟勤), 2012-07-25 20:34:35]

lgtm

LGTM (for adding unistd.h in sandbox/*)

[Han, 2012-07-25 22:28:44]

Hi all, thanks!

https://chromiumcodereview.appspot.com/10833017/diff/1/net/dns/dns_config_ser...
File net/dns/dns_config_service.cc (right):

https://chromiumcodereview.appspot.com/10833017/diff/1/net/dns/dns_config_ser...
net/dns/dns_config_service.cc:19: #define _C_(x) static_cast<unsigned char>(x)
On 2012/07/25 20:32:34, agl wrote:
> _C_ is an odd name for a macro. How about U8?

Done.

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
File webkit/plugins/npapi/test/plugin_execute_stream_javascript.cc (right):

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
webkit/plugins/npapi/test/plugin_execute_stream_javascript.cc:40:
javascript.append(static_cast<char*>(buffer), len);
On 2012/07/25 20:32:34, agl wrote:
> Not your fault, but while you're in the area: add a check that
> javascript.length() == static_cast<uint32_t>(javascript.length()) and return
an
> error otherwise.

Done.

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
File webkit/plugins/npapi/test/plugin_windowless_test.cc (right):

https://chromiumcodereview.appspot.com/10833017/diff/1/webkit/plugins/npapi/t...
webkit/plugins/npapi/test/plugin_windowless_test.cc:137: NPString script_string
= { script_url.c_str(),
On 2012/07/25 20:32:34, agl wrote:
> ditto.

Done.

[agl, 2012-07-25 23:12:56]

lgtm

[commit-bot: I haz the power, 2012-07-25 23:29:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shenhan@google.com/10833017/6002

[commit-bot: I haz the power, 2012-07-26 04:57:38]

Change committed as 148519