Issue 10833007: [Photo Editor] Make exif encoder more tolerant to non-standard EXIF data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833007: [Photo Editor] Make exif encoder more tolerant to non-standard EXIF data (Closed)

Created:
8 years, 5 months ago by Vladislav Kaznacheev

Modified:
8 years, 5 months ago

Reviewers:
Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Photo Editor] Make exif encoder more tolerant to non-standard EXIF data BUG=138967 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148369

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js	View	1	3 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Zvorygin

8 years, 5 months ago (2012-07-25 17:41:20 UTC) #2

LGTM, but consider using extended JSDoc syntax. It's supported by Intellij Idea,
and helps a lot with autocompletion and static checks.

https://chromiumcodereview.appspot.com/10833007/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js
(right):

https://chromiumcodereview.appspot.com/10833007/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js:325: *
@param {Object} tag EXIF tag object.
I'd recommend you to use extended notation:

@param {{format:number, id:number}}

https://chromiumcodereview.appspot.com/10833007/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js:390: *
@param {Object} directory EXIF directory.
{Object.<number, Object>}

https://chromiumcodereview.appspot.com/10833007/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js:392: *
@param {number} format Tag format (used in getComponentWidth).
... format used in {@link ExifEncoder#getComponentWidth}

https://chromiumcodereview.appspot.com/10833007/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/image_editor/exif_encoder.js:394: *
@return {Object} Tag found or created.
@return {{id:number, format:number, componentCount:number}}

Expand Messages | Collapse Messages