Issue 10833004: [Sync] Make P2PNotifier emit a notification only if some enabled types changed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10833004: [Sync] Make P2PNotifier emit a notification only if some enabled types changed (Closed)

Created:
8 years, 5 months ago by akalin

Modified:
8 years, 5 months ago

Reviewers:
rlarocque, dcheng

CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Make P2PNotifier emit a notification only if some enabled types changed Relaxed some integrations tests that failed because of this. A client with type X disabled shouldn't be expected to quiesce with other clients that with X enabled given a change to X. Cleaned up indentation in preferences integration test. BUG=138893 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148379

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -130 lines)			Patch
M	chrome/browser/sync/test/integration/two_client_apps_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc	View		23 chunks	+56 lines, -111 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_themes_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sync/notifier/p2p_notifier.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	sync/notifier/p2p_notifier_unittest.cc	View	1	5 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10833004/10001

8 years, 5 months ago (2012-07-25 17:54:29 UTC) #3

Change committed as 148379

Expand Messages | Collapse Messages

Issue 10833004: [Sync] Make P2PNotifier emit a notification only if some enabled types changed (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix unit test #

Patch Set 3 : Fixed MC_DeleteBookmarks #

Messages