Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 10833003: Add support for android in gpu test expections parser (Closed)

Created:
8 years, 5 months ago by yongsheng
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Add support for android in gpu test expections parser So the parser can know 'Android' platform. Also the failed case 'GPUTestExpectationsParserTest.WebGLTestExpectationsValidation' is passed. BUG=118542 TEST=content_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148719

Patch Set 1 #

Patch Set 2 : Enable the case #

Patch Set 3 : Refine according to zhenyao's comments #

Patch Set 4 : Add 2 whitespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build/android/gtest_filter/content_unittests_disabled View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_test_expectations_parser.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_test_expectations_parser_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yongsheng
Please help review it. I'm wondering whether to add one line like this in chrome/test/gpu/webgl_conformance_test_expectations.txt: ...
8 years, 5 months ago (2012-07-25 07:55:39 UTC) #1
Ken Russell (switch to Gerrit)
Mo should review this one.
8 years, 5 months ago (2012-07-25 20:36:17 UTC) #2
Zhenyao Mo
The change looks fine, but you should update the two unittests in gpu_test_expectations_parser_unittest.cc (AllModifiers and ...
8 years, 5 months ago (2012-07-25 21:25:50 UTC) #3
yongsheng
On 2012/07/25 21:25:50, Zhenyao Mo wrote: > The change looks fine, but you should update ...
8 years, 5 months ago (2012-07-26 01:27:30 UTC) #4
yongsheng
On 2012/07/26 01:27:30, yongsheng wrote: > On 2012/07/25 21:25:50, Zhenyao Mo wrote: > > The ...
8 years, 5 months ago (2012-07-26 04:05:01 UTC) #5
Zhenyao Mo
LGTM
8 years, 5 months ago (2012-07-26 17:05:23 UTC) #6
yongsheng
On 2012/07/26 17:05:23, Zhenyao Mo wrote: > LGTM thanks for your review.
8 years, 5 months ago (2012-07-27 00:11:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10833003/10002
8 years, 5 months ago (2012-07-27 00:11:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10833003/10002
8 years, 5 months ago (2012-07-27 01:14:47 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-27 04:08:59 UTC) #10
Change committed as 148719

Powered by Google App Engine
This is Rietveld 408576698