Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10832428: Add a query function for the scaling feature. (Closed)

Created:
8 years, 4 months ago by brettw
Modified:
8 years, 4 months ago
Reviewers:
Josh Horwich, Wez
CC:
chromium-reviews
Visibility:
Public.

Description

Add a query function for the scaling feature. We need to be able to query whether scaling is supported before creating a Graphics2D object so we know which code path to use. This just adds a function to do that checking. I also renamed Graphics2DDev to Graphics2D_Dev for consistency with the other Dev wrapper objects. TEST=none BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152829

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Test fixed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M ppapi/cpp/dev/graphics_2d_dev.h View 1 chunk +8 lines, -5 lines 1 comment Download
M ppapi/cpp/dev/graphics_2d_dev.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M ppapi/tests/test_graphics_2d.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
8 years, 4 months ago (2012-08-21 23:26:27 UTC) #1
Josh Horwich
LGTM http://codereview.chromium.org/10832428/diff/10001/ppapi/cpp/dev/graphics_2d_dev.h File ppapi/cpp/dev/graphics_2d_dev.h (right): http://codereview.chromium.org/10832428/diff/10001/ppapi/cpp/dev/graphics_2d_dev.h#newcode14 ppapi/cpp/dev/graphics_2d_dev.h:14: class Graphics2D_Dev : public Graphics2D { Just a ...
8 years, 4 months ago (2012-08-21 23:53:29 UTC) #2
brettw
TBR=wez for remoting/
8 years, 4 months ago (2012-08-22 21:46:51 UTC) #3
brettw
TBR=wez for remoting/
8 years, 4 months ago (2012-08-22 21:47:14 UTC) #4
Wez
8 years, 4 months ago (2012-08-23 00:02:47 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698