Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1451)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.h

Issue 10832411: Remove support for non-ssa optimizing code generation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_ia32.h
diff --git a/runtime/vm/flow_graph_compiler_ia32.h b/runtime/vm/flow_graph_compiler_ia32.h
index f2b059387ac0db2401d0a17ee07d6f42bb3ec900..3149496b3c05bb7d502814ca119b4150495b1993 100644
--- a/runtime/vm/flow_graph_compiler_ia32.h
+++ b/runtime/vm/flow_graph_compiler_ia32.h
@@ -29,7 +29,6 @@ class FlowGraphCompiler : public ValueObject {
FlowGraphCompiler(Assembler* assembler,
const FlowGraph& flow_graph,
bool is_optimizing,
- bool is_ssa,
bool is_leaf);
~FlowGraphCompiler();
@@ -53,8 +52,6 @@ class FlowGraphCompiler : public ValueObject {
static bool CanOptimize();
bool is_optimizing() const { return is_optimizing_; }
- bool is_ssa() const { return is_ssa_; }
-
const GrowableArray<BlockInfo*>& block_info() const { return block_info_; }
ParallelMoveResolver* parallel_move_resolver() {
return &parallel_move_resolver_;
@@ -186,10 +183,7 @@ class FlowGraphCompiler : public ValueObject {
intptr_t try_index);
Label* AddDeoptStub(intptr_t deopt_id,
intptr_t try_index_,
- DeoptReasonId reason,
- Register reg1 = kNoRegister,
- Register reg2 = kNoRegister,
- Register reg3 = kNoRegister);
+ DeoptReasonId reason);
void AddSlowPathCode(SlowPathCode* slow_path);
@@ -204,10 +198,6 @@ class FlowGraphCompiler : public ValueObject {
const Bool& bool_false() const { return bool_false_; }
const Class& double_class() const { return double_class_; }
- FrameRegisterAllocator* frame_register_allocator() {
- return &frame_register_allocator_;
- }
-
void SaveLiveRegisters(LocationSummary* locs);
void RestoreLiveRegisters(LocationSummary* locs);
@@ -286,6 +276,9 @@ class FlowGraphCompiler : public ValueObject {
void GenerateInlinedGetter(intptr_t offset);
void GenerateInlinedSetter(intptr_t offset);
+ // Perform a greedy local register allocation. Consider all registers free.
+ void AllocateRegistersLocally(Instruction* instr);
+
// Map a block number in a forward iteration into the block number in the
// corresponding reverse iteration. Used to obtain an index into
// block_order for reverse iterations.
@@ -313,14 +306,12 @@ class FlowGraphCompiler : public ValueObject {
GrowableArray<SlowPathCode*> slow_path_code_;
const GrowableObjectArray& object_table_;
const bool is_optimizing_;
- const bool is_ssa_;
const bool is_dart_leaf_;
const Bool& bool_true_;
const Bool& bool_false_;
const Class& double_class_;
- FrameRegisterAllocator frame_register_allocator_;
ParallelMoveResolver parallel_move_resolver_;
// Currently instructions generate deopt stubs internally by

Powered by Google App Engine
This is Rietveld 408576698