Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10832411: Remove support for non-ssa optimizing code generation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index ef8e9a3325f98033876d880a6cb2acc0f93ce5e3..e6456c7af53e866fa730196cddda1f1159b41e67 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -1100,9 +1100,7 @@ void StoreInstanceFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(original() != NULL);
Label* deopt = compiler->AddDeoptStub(original()->deopt_id(),
original()->try_index(),
- kDeoptInstanceGetterSameTarget,
- instance_reg,
- value_reg);
+ kDeoptInstanceGetterSameTarget);
// Smis do not have instance fields (Smi class is always first).
Register temp_reg = locs()->temp(0).reg();
ASSERT(temp_reg != instance_reg);
@@ -1487,11 +1485,9 @@ LocationSummary* PushArgumentInstr::MakeLocationSummary() const {
void PushArgumentInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
// In SSA mode, we need an explicit push. Nothing to do in non-SSA mode
- // where PushArgument is handled in FrameRegisterAllocator::AllocateRegisters.
- // Instead of popping the value it is left alone on the simulated frame
- // and materialized on the physical stack before the call.
+ // where PushArgument is handled by BindInstr::EmitNativeCode.
// TODO(fschneider): Avoid special-casing for SSA mode here.
- if (compiler->is_ssa()) {
+ if (compiler->is_optimizing()) {
ASSERT(locs()->in(0).IsRegister());
__ PushRegister(locs()->in(0).reg());
}

Powered by Google App Engine
This is Rietveld 408576698