Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: runtime/vm/object.h

Issue 10832410: Give a length field to stack bitmaps. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated review comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_descriptors_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 6d776181c32d930747fc46eee7d27ab437450561..45f8cb93af5ddc55f2bb7bff49e3dc00293c87ae 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -2342,7 +2342,8 @@ class Stackmap : public Object {
static const intptr_t kNoMinimum = -1;
bool IsObject(intptr_t index) const {
- return InRange(index) && GetBit(index);
+ ASSERT(InRange(index));
+ return GetBit(index);
}
RawCode* Code() const { return raw_ptr()->code_; }
@@ -2366,9 +2367,7 @@ class Stackmap : public Object {
Utils::RoundUp(length, kBitsPerByte) / kBitsPerByte;
return RoundedAllocationSize(sizeof(RawStackmap) + payload_size);
}
- static RawStackmap* New(intptr_t pc_offset,
- intptr_t length,
- BitmapBuilder* bmap);
+ static RawStackmap* New(intptr_t pc_offset, BitmapBuilder* bmap);
private:
void SetLength(intptr_t length) const { raw_ptr()->length_ = length; }
« no previous file with comments | « runtime/vm/code_descriptors_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698