corelib/src/comparable.dart - Issue 10832401: Gentle start with removing explicit interfaces

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: corelib/src/comparable.dart

Issue 10832401: Gentle start with removing explicit interfaces (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 // Dart core library.	5 // Dart core library.

6	6

7 interface Comparable {	7 abstract class Comparable {

8 int compareTo(Comparable other);	8 factory Comparable._uninstantiable() {

	9 throw const UnsupportedOperationException(

	10 "abstract class Comparable cannot be instantiated");

	11 }
	bakster 2012/08/24 06:32:50 I don't understand why this is needed. If the clas I don't understand why this is needed. If the class is abstract a new operation will throw an error. That should be sufficient. hausner 2012/08/24 15:25:45 I checked this with Gilad of course. He says that I checked this with Gilad of course. He says that an abstract class can be instantiated. It seems there is some confusion about the semantics of abstract classes. It might be worthwhile for you, Kasper and Gilad to confirm that you all have the same idea. On 2012/08/24 06:32:50, bak1 wrote: Show quoted text > I don't understand why this is needed. If the class is abstract a new operation > will throw an error. > That should be sufficient.
	12 abstract int compareTo(Comparable other);

9 }	13 }

OLD	NEW

« no previous file with comments | « no previous file | corelib/src/function.dart » ('j') | no next file with comments »