Issue 10832399: Fix compile error in iossim.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832399: Fix compile error in iossim. (Closed)

Created:
8 years, 4 months ago by lliabraa

Modified:
8 years, 4 months ago

Reviewers:
TVL, rohitrao (ping after 24h)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix compile error in iossim. A recent clang roll started causing the following warning: ../../../testing/iossim/iossim.mm:215:62: error: expression which evaluates to zero treated as a null pointer constant of type 'BOOL *' (aka 'signed char *') [-Werror,-Wnon-literal-null-conversion]. Just dropping the isDirectory parameter fixes the issue. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152425

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	testing/iossim/iossim.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10832399/1

8 years, 4 months ago (2012-08-20 19:28:06 UTC) #3

Change committed as 152425

Expand Messages | Collapse Messages