Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 10832392: Fix leak in Mac PowerSaveBlocker. (Closed)

Created:
8 years, 4 months ago by Avi (use Gerrit)
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix leak in Mac PowerSaveBlocker. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/power_save_blocker_mac.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
8 years, 4 months ago (2012-08-20 15:14:52 UTC) #1
Avi (use Gerrit)
Robert is out today. Nico, can you take this?
8 years, 4 months ago (2012-08-20 15:35:36 UTC) #2
Nico
LGTM SysUTF8ToCFStringRef() should have a more obvious name :-/
8 years, 4 months ago (2012-08-20 15:50:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10832392/1
8 years, 4 months ago (2012-08-20 15:52:02 UTC) #4
Avi (use Gerrit)
On 2012/08/20 15:50:57, Nico wrote: > LGTM > > SysUTF8ToCFStringRef() should have a more obvious ...
8 years, 4 months ago (2012-08-20 15:53:26 UTC) #5
commit-bot: I haz the power
Try job failure for 10832392-1 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-20 18:25:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10832392/1
8 years, 4 months ago (2012-08-20 18:37:48 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 00:06:00 UTC) #8
Change committed as 152440

Powered by Google App Engine
This is Rietveld 408576698