Issue 10832391: Disable TabposeWindowTest.TestShow on MacOSX 10.7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832391: Disable TabposeWindowTest.TestShow on MacOSX 10.7 (Closed)

Created:
8 years, 4 months ago by bryeung

Modified:
8 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable TabposeWindowTest.TestShow on MacOSX 10.7 See http://code.google.com/p/chromium/issues/detail?id=127845 BUG=127845 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152323

Patch Set 2 : skip correctly #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/tabpose_window_unittest.mm	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/10832391/diff/1/chrome/browser/ui/cocoa/tabpose_window_unittest.mm File chrome/browser/ui/cocoa/tabpose_window_unittest.mm (right): http://codereview.chromium.org/10832391/diff/1/chrome/browser/ui/cocoa/tabpose_window_unittest.mm#newcode38 chrome/browser/ui/cocoa/tabpose_window_unittest.mm:38: #if defined(MAC_OS_X_VERSION_10_7) Hm, this won't work. MAC_OS_X_VERSION_10_7 always evaluates ...

8 years, 4 months ago (2012-08-20 14:53:11 UTC) #2

bryeung

8 years, 4 months ago (2012-08-20 15:07:29 UTC) #5

thanks!

On Mon, Aug 20, 2012 at 11:05 AM,  <thakis@chromium.org> wrote:
> lgtm
>
> I'll try to look at this test today.
>
> https://chromiumcodereview.appspot.com/10832391/

Expand Messages | Collapse Messages

Issue 10832391: Disable TabposeWindowTest.TestShow on MacOSX 10.7 (Closed)

Description

Patch Set 1 #

Patch Set 2 : skip correctly #

Messages