content/renderer/gpu/gpu_benchmarking_extension.cc - Issue 10832379: Initialize FilePath with FilePath::FilePath(string) instead of FilePath::AppendASCII(string).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/gpu_benchmarking_extension.cc

Issue 10832379: Initialize FilePath with FilePath::FilePath(string) instead of FilePath::AppendASCII(string). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/gpu/gpu_benchmarking_extension.cc

===================================================================

--- content/renderer/gpu/gpu_benchmarking_extension.cc (revision 151503)

+++ content/renderer/gpu/gpu_benchmarking_extension.cc (working copy)

@@ -224,8 +224,8 @@

if (!benchmark_support)

return v8::Undefined();

- FilePath dirpath;

- dirpath = dirpath.AppendASCII(*dirname);

+ FilePath dirpath(FilePath::StringType(*dirname,

+ *dirname + dirname.length()));

if (!file_util::CreateDirectory(dirpath) ||

!file_util::PathIsWritable(dirpath)) {

std::string msg("Path is not writable: ");

« no previous file with comments | « no previous file | no next file » | no next file with comments »