Issue 10832379: Initialize FilePath with FilePath::FilePath(string) instead of FilePath::AppendASCII(string).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832379: Initialize FilePath with FilePath::FilePath(string) instead of FilePath::AppendASCII(string). (Closed)

Created:
8 years, 4 months ago by alokp

Modified:
8 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Initialize FilePath with FilePath::FilePath(string) instead of FilePath::AppendASCII(string). FilePath::AppendASCII(string) expects string to be relative path only. BUG=142421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152248

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/renderer/gpu/gpu_benchmarking_extension.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/10832379/1

8 years, 4 months ago (2012-08-18 04:39:09 UTC) #3

Change committed as 152248

Expand Messages | Collapse Messages