Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 10832375: Add correctly sized 2x assets for remaining mismatches. (Closed)

Created:
8 years, 4 months ago by flackr
Modified:
8 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Add correctly sized 2x assets for remaining mismatches. BUG=131586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152778

Patch Set 1 #

Patch Set 2 : Add last correctly sized resource. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-11 lines, --11 lines) Patch
D chrome/app/theme/default_100_percent/speech_input_mic_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/speech_input_mic_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/speech_input_mic_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/speech_input_mic_noise.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/speech_input_spinner.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/chromium/product_logo.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/chromium/product_logo_white.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/speech_input_mic_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/speech_input_mic_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/speech_input_mic_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/speech_input_mic_noise.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/speech_input_spinner.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/update_uptodate.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/resources/default_200_percent/ash/status_less.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/ash/status_more.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/menu_check.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
flackr
Landing correctly sized 2x assets. I've moved some to their proper directories where the set ...
8 years, 4 months ago (2012-08-17 19:09:25 UTC) #1
oshima
8 years, 4 months ago (2012-08-20 20:28:44 UTC) #2
On 2012/08/17 19:09:25, flackr wrote:
> Landing correctly sized 2x assets. I've moved some to their proper directories
> where the set of related resources to be moved is small, but let me know if
you
> want me to move around more. Thanks!

LGTM

I assume you updated the path of speech_input*png to those that are already
checked in from gdrive. Just asking to make sure that we're using the same
file names used in gdrive.

Powered by Google App Engine
This is Rietveld 408576698