Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10832365: Rename Context::global to Context::global_object, (Closed)

Created:
8 years, 4 months ago by rossberg
Modified:
8 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Rename Context::global to Context::global_object, in preparation for global lexical scope. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12335

Patch Set 1 #

Total comments: 20

Patch Set 2 : Addressed Michael's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -218 lines) Patch
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/builtins-arm.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 7 chunks +12 lines, -11 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 13 chunks +19 lines, -16 lines 0 comments Download
M src/compiler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/contexts.h View 3 chunks +7 lines, -5 lines 0 comments Download
M src/contexts.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 9 chunks +12 lines, -10 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/heap.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 7 chunks +12 lines, -11 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 15 chunks +17 lines, -17 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/test-heap.cc View 1 9 chunks +15 lines, -12 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-random.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
8 years, 4 months ago (2012-08-17 11:48:55 UTC) #1
Michael Starzinger
LGTM (with a few nits). https://chromiumcodereview.appspot.com/10832365/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/10832365/diff/1/src/arm/code-stubs-arm.cc#newcode4510 src/arm/code-stubs-arm.cc:4510: // Get the arguments ...
8 years, 4 months ago (2012-08-17 12:44:57 UTC) #2
rossberg
8 years, 4 months ago (2012-08-17 12:55:44 UTC) #3 
https://chromiumcodereview.appspot.com/10832365/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://chromiumcodereview.appspot.com/10832365/diff/1/src/arm/code-stubs-arm...
src/arm/code-stubs-arm.cc:4510: // Get the arguments boilerplate from the
current (native) context into r4.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/arm/code-stubs-arm...
src/arm/code-stubs-arm.cc:4690: // Get the arguments boilerplate from the
current (native) context.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/ia32/code-stubs-ia...
File src/ia32/code-stubs-ia32.cc (right):

https://chromiumcodereview.appspot.com/10832365/diff/1/src/ia32/code-stubs-ia...
src/ia32/code-stubs-ia32.cc:3437: // Get the arguments boilerplate from the
current (native) context into edi.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/ia32/code-stubs-ia...
src/ia32/code-stubs-ia32.cc:3630: // Get the arguments boilerplate from the
current (native) context.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/mips/code-stubs-mi...
File src/mips/code-stubs-mips.cc (right):

https://chromiumcodereview.appspot.com/10832365/diff/1/src/mips/code-stubs-mi...
src/mips/code-stubs-mips.cc:4649: // Get the arguments boilerplate from the
current (native) context into t0.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/mips/code-stubs-mi...
src/mips/code-stubs-mips.cc:4844: // Get the arguments boilerplate from the
current (native) context.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://chromiumcodereview.appspot.com/10832365/diff/1/src/x64/code-stubs-x64...
src/x64/code-stubs-x64.cc:2459: // Get the arguments boilerplate from the
current (native) context into rdi.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/x64/code-stubs-x64...
src/x64/code-stubs-x64.cc:2675: // Get the arguments boilerplate from the
current (native) context.
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Drop the parenthesis.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://chromiumcodereview.appspot.com/10832365/diff/1/src/x64/stub-cache-x64...
src/x64/stub-cache-x64.cc:231: Operand(rsi,
Context::SlotOffset(Context::GLOBAL_OBJECT_INDEX)));
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Indentation seems off.

Done.

https://chromiumcodereview.appspot.com/10832365/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://chromiumcodereview.appspot.com/10832365/diff/1/test/cctest/test-heap....
test/cctest/test-heap.cc:234:
Isolate::Current()->context()->global_object()->HasLocalProperty(*name));
On 2012/08/17 12:44:57, Michael Starzinger wrote:
> Better break that after "global_object()->".

Done.

Powered by Google App Engine
This is Rietveld 408576698