Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10832363: In the extension docs builder, allow DOM nodes to be specified as "volatile" (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin
Modified:
8 years, 3 months ago
Reviewers:
ernestd, ernestd1
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

In the extension docs builder, allow DOM nodes to be specified as "volatile" so that they aren't removed as part of the doc generation. This fixes the samples page filter. BUG=139107 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153447

Patch Set 1 #

Patch Set 2 : make install CRX link volatile #

Patch Set 3 : back to hiding the Install Extension links #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/common/extensions/docs/extensions/samples.html View 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/static/samples.html View 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
(In any case, the docs build system should be going away very soon)
8 years, 4 months ago (2012-08-17 06:15:41 UTC) #1
not at google - send to devlin
8 years, 4 months ago (2012-08-21 23:52:54 UTC) #2
ernestd1
Hi Ben, As I mention in #139107, I think there were more relevant nodes removed ...
8 years, 4 months ago (2012-08-23 06:28:15 UTC) #3
not at google - send to devlin
I looked at the install crx thing and the only extension that has such a ...
8 years, 4 months ago (2012-08-23 06:49:13 UTC) #4
ernestd1
8 years, 4 months ago (2012-08-23 16:41:35 UTC) #5
Fair enough,
LGTM

On 2012/08/23 06:49:13, kalman wrote:
> I looked at the install crx thing and the only extension that has such a link
is
> the extension-questions.crx file, which still shows up in those docs.
> 
> Perhaps a bunch of crx files were deleted or something?
> 
> I made the link volatile but, as expected, most things are display:none and
> don't appear to change with the dynamic javascript.

Powered by Google App Engine
This is Rietveld 408576698